voidcosmos / voidcosmos/npkill

Issue with pnpm and Windows

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
9.4k
Forks
254
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
I have installed node modules using pnpm and using npkill causes an error

To Reproduce
Steps to reproduce the behavior:

  1. Run pnpm install in any node project
  2. Try to use npkill through the command pnpx npkill
  3. Select the project
  4. Error

The following error happens on pretty much the whole .pnpm folder:

Error: ENOTEMPTY: directory not empty, rmdir 'C:\Repos\Testing\node_modules\.pnpm\registry.npmjs.org\yargs

  • OS: Windows
  • Version: v0.7.0

FYI, the pnpm folders use syslinks extensively. I understand this tool is not meant to support pnpm, but maybe the solution to such issue is as simple as changing a few lines and achieving full compatibility with pnpm.

Apparently, using rmdir command on Windows works.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start on Windows by reproducing the failure with pnpm install and pnpx npkill, focusing on deletion of the .pnpm folder and its symlinks. Compare the current behavior with the reported Windows rmdir approach; done means selecting the project no longer produces ENOTEMPTY errors for pnpm-installed modules.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.