void-linux / void-linux/void-packages
xbps-src: XBPS_CHECK_PKGS with cross-builds
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 3.4k
- Forks
- 2.8k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 299
Description
XBPS_CHECK_PKGS is a global "do we test packages" check, set with the -Q option or in etc/conf.
During cross builds this variable is still set true despite checkdepends not being installed and do_check not being used.
A lot of templates just check [ "$XBPS_CHECK_PKGS" ] which works in most cases, but not in cases where its used to explicitly disable tests because the build system might depend on something in checkdepends if tests are enabled:
if [ -z "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=false"
fi
xbps-src itself usually does a check like [ "$XBPS_CHECK_PKGS" ] && [ -z "$XBPS_CROSS_BUILD" ].
I think we should either change XBPS_CHECK_PKGS to indicate whether checks are going to be run or add a new variable for that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with xbps-src handling of XBPS_CHECK_PKGS and XBPS_CROSS_BUILD, then inspect the default in etc/conf and templates that use the variable to disable tests. Determine and document the intended cross-build semantics, then verify that package checks and checkdepends-dependent test configuration behave consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100