void-linux / void-linux/void-packages

Regression through update to Flameshot v13.3

Open
#59,462 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-testing
Dominant language
Shell
Stars
3.4k
Forks
2.8k
Avg merge
2d 5h
Merged PRs (30d)
299

Description

Is this a new report?

Yes

System Info

Void 6.12.77_1 x86_64 AuthenticAMD uptodate rrrrm

Package(s) Affected

flameshot-13.3.0_1

Does a report exist for this bug with the project's home (upstream) and/or another distro?

https://github.com/flameshot-org/flameshot/issues/4111

Expected behaviour

When flameshot gui is run, the overlay appears without offset.

Actual behaviour

When flameshot gui is run, the overlay appears with offset.

Steps to reproduce

Install and run Flameshot v13.3 via official repositories with flameshot gui option. This might be system-specific but is well documented upstream.
I am running a multi-monitor setup with Xorg and Xfce, no tweaks besides scaling on one display and some panel add-ons.

Further information:

The update from version 12.1 to 13.3 of Flameshot causes a regression in functionality documented on Flameshot's GitHub page.

I verified that version 12.1 is not affected as such:

Repository version:
$ flameshot -v
"No Qt translation found for English"
Flameshot v13.3.0 ()
Compiled with Qt 6.10.2
Fix:

I cloned the void-packages repository.
git checkout dbf1b9c568edd75da856bef367131d9fa0e782ab https://github.com/void-linux/void-packages/commit/dbf1b9c568edd75da856bef367131d9fa0e782ab

cp -r srcpkgs/flameshot/ ..
git checkout master 
rm -rf srcpkgs/flameshot/ 
cp -r ../flameshot/ srcpkgs/flameshot/
./xbps-src binary-bootstrap
./xbps-src pkg flameshot
sudo xbps-install -R hostdir/binpkgs -f flameshot

Killed old Flameshot background process.

$ flameshot -v
Flameshot v12.1.0 (-)
Compiled with Qt 5.15.11

flameshot &

Hit keyboard shortcut to make screenshot. This triggers flameshot gui in my case.

Issue was resolved.

I also built version 13.3.0_1 from source using the template on the master branch. https://github.com/void-linux/void-packages/commit/62cfe0c7b6c8dc4e09df6c01ea9747fe539663a3 This showed the same issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading upstream Flameshot issue 4111 and comparing the flameshot package directory at the referenced pre-13.3 commit with the current master template. Reproduce flameshot gui on the described multi-monitor Xorg/Xfce setup and confirm whether the Void package can address the regression. Done means the packaged version no longer shows the offset, or the issue is clearly tracked as an upstream-only problem.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.