void-linux / void-linux/void-packages

[RFC] unvendor desktop files, icons, and similar files from the srcpkgs tree

Open
#49,164 1 comment 14 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted tracking
Dominant language
Shell
Stars
3.4k
Forks
2.8k
Avg merge
2d 5h
Merged PRs (30d)
299

Description

there are a number of packages that include void-created .desktop files, icons, and sometimes even other things like manual pages in srcpkgs/<pkg>/files/, when files like this should come from upstream or not at all. In a quick survey I did in the past, some of the vendored desktop files even have upstream-provided ones available! (in those cases, the desktop files we have are often outdated or different from upstream)

A rough count finds:

  • 91 .desktop files (a few should stay, like pipewire's)
  • 43 PNG, 2 xpm, and 2 SVG icons

IMO, most, if not all, of these should be removed and either replaced with an existing upstream one or contributed upstream. I'd be interested in working on that if it is desired.

It would also be nice to add some kind of lint for the future to prevent these from slipping in again, as I see it often in new package PRs.

@void-linux/pkg-committers thoughts?

  • Maelstrom
  • OpenJK - may need to upstream
  • PrusaSlicer
  • QSyncthingTray - abandoned upstream
  • Rocket.Chat-Desktop
  • Signal-Desktop
  • SweetHome3D
  • WindowMaker
  • XyGrib
  • Z80Explorer
  • android-studio
  • apache-directory-studio-bin
  • arduino
  • astromenace
  • blobby2
  • boinc
  • boswars - https://codeberg.org/boswars/boswars/pulls/43
  • caph
  • cavestory
  • chatty
  • clipgrab
  • darkplaces
  • dbeaver
  • doom3
  • dosbox
  • dot-xsession
  • dwm
  • eclipse
  • element-desktop
  • evilwm
  • fluxbox
  • freeplane
  • freerouting
  • fsv
  • gnurobbo
  • godot
  • gtkedit
  • imagescan
  • intellij-idea-community-edition
  • jmol
  • jwm
  • kickshaw
  • lbreakout2
  • marvin
  • maxima
  • mplayer
  • mupdf
  • netsurf
  • opensonic
  • pa-applet
  • pingus
  • pipenightdreams
  • polkit-gnome
  • pycharm-community
  • pymol
  • python-tkinter
  • python3-tkinter
  • qt5
  • quakespasm - #52045
  • quimup
  • rocksndiamonds
  • rox
  • runelite-launcher
  • rxvt-unicode
  • scid_vs_pc
  • sopwith
  • teamspeak3
  • tesseract
  • thunderbird
  • urbanterror
  • vapoursynth-editor
  • vkQuake
  • warsow
  • wm2
  • wmderland
  • wmx
  • xdemineur
  • xnec2c
  • xonotic - #51975
  • yquake2
  • zsnes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the listed packages under srcpkgs//files/ and check which desktop files, icons, and manual pages are Void-created versus available upstream. Use the checked and unchecked items to define the cleanup scope, noting cases that may need upstream contributions. Done means agreed files are removed or replaced and a future lint approach is defined.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.