vnotex / vnotex/vnote

regression in `v_native` theme

Open
#658 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
13k
Forks
1.3k
Avg merge
14h 3m
Merged PRs (30d)
3

Description

spotted the regression with v_native theme, not only foreground color not distinguishable but also system font got overridden:

2019-03-06--1551882095_1997x2082_scrot

here's with blank qss as was discussed in this ticket https://github.com/tamlok/vnote/issues/148:

2019-03-06--1551882056_1997x2082_scrot

Originally posted by @actionless in https://github.com/tamlok/vnote/issues/258#issuecomment-470125554

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the regression with the v_native theme and compare it with the blank-QSS screenshots linked in the issue. Trace the theme styling responsible for foreground colors and system fonts; the work is done when text is distinguishable and the system font is no longer overridden.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
design, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.