vmware / vmware/vsphere-supervisor
toggle_software_depot_oci_image_upload.sh misspelled state check
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 28
- Forks
- 12
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 3
Description
Describe the bug
The API states are:
- PENDING
- SCHEDULED
- RUNNING
- SUCCEEDED
- FAILED
- CANCELED
Please check for "Failed|Canceled|Cancelled" rather than "Failed|Cancelled"
(Kept the original spelling as well to catch misspelling in API description, as a breadcrumb in case we match on that field later)
--
Less important, but to be pedantic, please consider the following additional change:
-TASK_ID="$(curl -k -sS -XPOST -H "Authorization: Bearer ${TOKEN}"
+TASK_ID="$(curl -k -sS -XPOST \
- -H "Authorization: Bearer ${TOKEN}" \
- -H "Content-Type: application/json" \
Reproduction steps
1.Canceled state is never captured.
2.
3.
...
Expected behavior
Canceled state is captured as well as Failed state
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open toggle_software_depot_oci_image_upload.sh and inspect its upload-state check. Update the check so both Canceled and Failed states are captured, preserving the existing spelling as a breadcrumb; consider also adding the JSON Content-Type header shown in the issue. Done means the Canceled state is recognized and the request includes the requested header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100