vmware / vmware/splinterdb

Check that `memtable_ok_to_lookup[_compacted]` are safe

Open
#153 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
732
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Also add some checks in the code

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementations and call sites of memtable_ok_to_lookup and memtable_ok_to_lookup_compacted, then inspect the surrounding code to determine what safety checks are missing. The issue is complete when appropriate checks have been added and their behavior is covered by relevant tests, though no test file is identified here.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.