vmware / vmware/singleton

[ENHANCEMENT] Implement product-version-component-specific fetching and caching of ProductService.getSupportedLanguageTags

Open
#870 0 comments 0 reactions 2 assignees View on GitHub

@huihuiw01 is already working on this.

Since Nov 12, 2020.

area/java-client kind/feature priority/low
Dominant language
Java
Stars
72
Forks
69
Avg merge
23h 32m
Merged PRs (30d)
4

Description

Is your feature request related to a problem? Please describe.
ProductService.getSupportedLanguageTags collects all locales under all components in the main app's offlineResourceBaseURL. A wrong locale&component combination may happen. For instance, 2 components in the main app may have different sets of bundles at some point (e.g. component A's translations are ready but component B's translations are not ready yet), so they have different sets of supported locales. This gives a false positive for some combinations which results to trying to fetch the bundle even if the combination doe not exist.

Describe the solution you'd like
In my opinion, getSupportedLanguageTags should be fetched and cached per product component and used accordingly. The solution should apply to both main app and shared libs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.