vmware / vmware/singleton

[BUG/DESIGN] g11n-java-client - VIP configuration for root application always applies to the shared library, except for product name and version

Open
#755 1 comment 0 reactions 3 assignees View on GitHub

@jessiejuachon is already working on this.

Since Nov 3, 2020.

  • #858 by @jessiejuachon — open
area/java-client kind/bug kind/design priority/high
Dominant language
Java
Stars
72
Forks
69
Avg merge
23h 32m
Merged PRs (30d)
4

Description

Describe the bug
Any shared library that uses the Java client library is forced to use the VIP configurations of the root application (except for product name and version config).

To Reproduce
Steps to reproduce the behavior:

  1. Use shared library in a root application
  2. Add configurations for shared library that are different from the root app's config (eg. offlineResourcesBaseUrl, vipServer)
  3. Notice that only the shared library's productName and version configs are used. The root app's configs are used for the rest.

Expected behavior
In the root application, you should be able to set the shared library's own VIP configurations properly and use it.

For example, the shared library should be able to use its own offlineResourcesBaseUrl config if its l10n files are bundled with the shared library's jar.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.