vmware / vmware/singleton

[BUG] [Angular Client]Pattern still fall back to en-US even though defaultLocale is set as NOT en-US locale.

Open
#216 0 comments 0 reactions 2 assignees View on GitHub

@pengrongbo is already working on this.

Since Sep 27, 2019.

area/angular-client kind/bug priority/medium
Dominant language
Java
Stars
72
Forks
69
Avg merge
23h 32m
Merged PRs (30d)
4

Description

Describe the bug
Pattern still fall back to en-US even though defaultLocale is set as NOT en-US locale.

To Reproduce
Steps to reproduce the behavior:

  1. Set default locale in your app with below:
    localeService.setDefaultLocale({
    languageCode: 'ja',
    languageName: 'Japanese',
    regionCode: 'JP',
    regionName: 'Japan'
    })
  2. Adding ja pattern file(locale_ja.ts) to scr/data directory.
  3. Requesting the ja-JP translation and pattern.

Expected behavior
Can get ja_JP pattern from local stored file(locale_ja.ts).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.