Erroneous String Compare
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 72
- Forks
- 69
- Avg merge
- 23h 32m
- Merged PRs (30d)
- 4
Description
https://github.com/vmware/singleton/blob/3e000ea58db1547d16512f27297d0de7a6feb0ea/g11n-ws/modules/md-service-i18n-l3/src/main/java/com/vmware/vip/core/messages/utils/LocaleUtility.java#L69
https://github.com/vmware/singleton/blob/3e000ea58db1547d16512f27297d0de7a6feb0ea/g11n-ws/vip-common/src/main/java/com/vmware/vip/common/utils/LocaleUtils.java#L88
Strings should be compared with the equals() method, not == or !=.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review LocaleUtility.java at line 69 and LocaleUtils.java at line 88 in the two linked Java files, focusing on the string comparisons identified in the issue. Replace the erroneous comparisons with equals()-based comparisons and confirm both locations no longer use == or != for strings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- internationalization, localization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100