vmware / vmware/singleton

[BUG][Ruby Client] The client library does not use etag and If-none-match to reduce network payload

Open
#1,474 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

area/ruby-client kind/bug priority/low
Dominant language
Java
Stars
72
Forks
69
Avg merge
23h 32m
Merged PRs (30d)
4

Description

Describe the bug
The client library does not use etag and if-none-match to reduce network payload.

To Reproduce
Steps to reproduce the behavior:

  1. Run a sample Ruby application that uses the Singleton Ruby client library in online mode.
  2. Trigger a an action that sends a request to the Singleton service to fetch data and load data in cache.
  3. Notice that the Singleton service responds with an HTTP 200 OK, with an eTag header.
  4. After the data in cache has expired, trigger the same action.
  5. Error: Notice that the HTTP request does not include an If-none-match header.

Expected behavior
The HTTP request in step 5 should have included an If-none-match header with value the same as the value of the eTag header in Step 3.

Additional context
https://confluence.eng.vmware.com/display/GQ/Etag+and+Cache-Control

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.