vmware / vmware/singleton

[BUG] The JS client library is parsing only the first component from VIP's response.

Open
#1,100 0 comments 0 reactions 1 assignee View on GitHub

@jessiejuachon is already working on this.

Since May 11, 2021.

  • #1101 by @jessiejuachon — open
area/js-client kind/bug
Dominant language
Java
Stars
72
Forks
69
Avg merge
23h 32m
Merged PRs (30d)
4

Description

Describe the bug
When processing the response of translation-with-pattern-api of VIP service, only the messages from the first component is parsed. So in the case of multiple components, the VIP service responds correctly with multiple array values, but the JS client only looks at components[0].

To Reproduce
Steps to reproduce the behavior:

  1. Create a sample JS application that uses the JS client library.
  2. Configure to fetch for multiple components:
    const vipConfig = {
    productID: 'Product',
    version: '1.0.0',
    component: ['component-1', 'component-2', 'component-3'],
    }
  3. Run the sample application and notice that the http request to VIP is correct with multiple components.
  4. Notice that only the strings from the first component are available (the others will display source strings instead)

Expected behavior
All components in the response must be parsed and stored in the client-side "cache".

Additional context
The linked pull request is what I used to to move forward with a PoC I am doing. I only added it for reference. To whowever is picking up this bug, please create a your own pull request that you can track to completion. Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.