vmware / vmware/pinniped

Make it easier to configure my IDP by having something better than a log statement to tell me what my upstream IDP said about me

Open
#910 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement priority/undecided
Dominant language
Go
Stars
739
Forks
85
Avg merge
5d 5h
Merged PRs (30d)
1

Description

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  • @enj said ["I would like to have an API that could be used via the CLI to aid in a user determining their upstream IDP said about them (generically for all IDPs)"|https://kubernetes.slack.com/archives/C01BW364RJA/p1639064773170300?thread_ts=1639059009.168900&cid=C01BW364RJA]
  • That solution sounds like it could fit into a broader "make Pinniped easier to debug" story, which is appealing to me

Describe alternatives you've considered

  • Uh, the logging thing above, and not much else

Are you considering submitting a PR for this feature?

  • How will this project improvement be tested?
    TBD
  • How does this change the current architecture?
    TBD
  • How will this change be backwards compatible?
    TBD
  • How will this feature be documented?
    TBD

Additional context

This feature came from this discussion: https://kubernetes.slack.com/archives/C01BW364RJA/p1639059009168900

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with internal/upstreamoidc/upstreamoidc.go at the referenced plog.LevelAll log statement and review the linked discussion about a CLI/API. Define a generic way to expose upstream IDP claims or attributes for OIDC and LDAP, then establish how the behavior should be tested and documented. Done means users can inspect what their upstream IDP reported without relying on logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication, cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.