[stub] make defensive changes to pinniped CLI to handle clock skew
Open
Nobody has claimed this yet.
enhancement
priority/undecided
- Dominant language
- Go
- Stars
- 739
- Forks
- 85
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 1
Description
As a defensive change to handle https://github.com/kubernetes/kubernetes/pull/106768 I propose that the pinniped CLI:
- Not send
expirationTimestamptoclient-go/kubectl- maybe allow this to be opt-ed into? - or a better approach may be to make sureexpirationTimestampis>=totime.Now() + 10*time.Second - Cache credentials until
expirationTimestamportime.Now() + 10*time.Second, whichever is later - (not the CLI) add a controller that detects clock skew and emits warning logs / status updates?
- We also need to fix the issue upstream which might require invasive changes and difficult to write tests
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the Kubernetes pull request linked in the issue and trace how the pinniped CLI sends expirationTimestamp and caches credentials. Before implementation, establish which of the proposed CLI or controller changes is in scope; done requires an agreed behavior and tests covering clock skew, but no test files are named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication, cli
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100