vmware / vmware/pinniped

Add retry logic to the upstream OIDC refresh request

Open
#869 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement estimate/S priority/undecided
Dominant language
Go
Stars
739
Forks
85
Avg merge
5d 5h
Merged PRs (30d)
1

Description

In the new upstream refresh feature started in #858, when there is a network connectivity failure to the upstream IDP, then it would be nice to retry the request a couple/few times, or maybe do a backoff-style retry loop for a short time. Otherwise, a single network glitch between the Supervisor pods and the upstream IDP would cause the user's session to end.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the upstream refresh feature referenced in #858 and trace the request to the upstream IDP. Add short-lived retries for network connectivity failures, then verify that a transient glitch does not end the user's session.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.