testlib: invalid assumption about nil return from recover()
Open
Beginner friendly
Nobody has claimed this yet.
chore
priority/undecided
- Dominant language
- Go
- Stars
- 739
- Forks
- 85
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 1
Description
This code is incorrect:
because a test can fail with panic(nil).
The go std lib testing package handles this correctly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/testlib/assertions.go at lines 51-52, then compare the behavior with the linked implementation in Go's testing package. Update the assertion handling so a test that calls panic(nil) is handled correctly, and verify that the relevant testlib behavior no longer treats that panic as no panic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100