vmware / vmware/pinniped

[stub] DeleteByLabel should delete all secrets and return an aggregated error

Open
#762 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

chore
Dominant language
Go
Stars
739
Forks
85
Avg merge
5d 5h
Merged PRs (30d)
1

Description

https://github.com/vmware-tanzu/pinniped/blob/65fa47cbcdcd923ce667c0d0d589478bd0e5058b/internal/crud/crud.go#L130-L151

We should accumulate all errors with NewAggregate and then FilterOut IsNotFound errors.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in internal/crud/crud.go at lines 130-151 and inspect DeleteByLabel. Verify that it processes every matching secret, accumulates errors with NewAggregate, and filters out IsNotFound errors. Done means all secrets are attempted and the returned error reflects the remaining failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.