vmware / vmware/pinniped

[stub] check for deletion timestamp in supervisor Kube storage

Open
#761 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority/undecided
Dominant language
Go
Stars
739
Forks
85
Avg merge
5d 5h
Merged PRs (30d)
1

Description

https://github.com/vmware-tanzu/pinniped/blob/65fa47cbcdcd923ce667c0d0d589478bd0e5058b/internal/crud/crud.go#L98

We should probably fail validation with a not found error if deletion timestamp is not nil.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in internal/crud/crud.go at the linked line and inspect how supervisor Kube storage validation handles deletion timestamps. Confirm the expected not-found error behavior for a non-nil deletion timestamp, then verify the relevant validation behavior with the repository's existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.