Watch failures in CI should cause the server to crash
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 739
- Forks
- 85
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 1
Description
Is your feature request related to a problem? Please describe.
#377 caused no failures even though something was clearly broken. DefaultWatchErrorHandler was just happily logging the error and we did not notice.
Describe the solution you'd like
Straw dog: update the process global utilruntime.ErrorHandlers to panic on such errors but only in CI.
Describe alternatives you've considered
None.
Are you considering submitting a PR for this feature?
N/A
- How will this project improvement be tested?
After this functionality is in place, we could revert (in a PR) the RBAC changes needed to fix #377 and confirm that CI fails.
- How does this change the current architecture?
- How will this change be backwards compatible?
- How will this feature be documented?
Additional context
Add any other context or screenshots about the feature request here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DefaultWatchErrorHandler and the process-global utilruntime.ErrorHandlers usage, then inspect how CI is detected and how watch failures are handled. Done means watch errors cause the server to fail in CI without changing non-CI behavior, with CI coverage that demonstrates a failure such as the one described for #377.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- backend, ci-cd
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100