check_spec_files fails

Open

#1,534 opened on Jan 18, 2024 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug

Dominant language: C
Stars: 3.2k
Forks: 692
PR merge metrics: No merged PRs in 30d

Description

Describe the bug

I'm trying to build packages, bu the check_spec_files step fails.

Reproduction steps

git checkout 550a466822b07eaa0b11c
sudo make packages-minimal

Expected behavior

Build passes

Additional context

Sanity check for all json files ...
Checking all python code is compilable ...

Creating staging folder and subitems...
Pulling toolchain XRPMS...
Pulling toolchain RPMS...
Checking spec file: SPECS/linux/linux-rt-drivers-intel-ice-1.9.11.spec

Some mentioned but unused files found in the spec.
If you think it's a false positive, try the following methods:

If you are using Photon OS, update rpm version to latest using tdnf and retry
If you are using any other distro, contact - 'sshedi@vmware.com'

--- List of errors in SPECS/linux/linux-rt-drivers-intel-ice-1.9.11.spec ---

--- List of unused files ---
List of unused files in: SPECS/linux
ice-1.9.11.tar.gz

Spec file check failed
Traceback (most recent call last):
File "/data/git/photon/build.py", line 1593, in main
attr = getattr(RpmBuildTarget(), configdict["targetName"])
File "/data/git/photon/build.py", line 634, in init
CheckTools.check_spec_files()
File "/data/git/photon/build.py", line 985, in check_spec_files
raise Exception("Spec file check failed")
Exception: Spec file check failed
make: *** [Makefile:6: packages-minimal] Error 1

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Reproduce the failure with make packages-minimal at commit 550a466822b07eaa0b11c, then inspect build.py, especially CheckTools.check_spec_files(), and SPECS/linux/linux-rt-drivers-intel-ice-1.9.11.spec. Check how ice-1.9.11.tar.gz is referenced and determine what change makes the package build pass without the unused-file error.

Written by the indexing model from the issue text.

Assessment

Tech stack: linux, python
Domain: build-system, operating-systems
Issue type: Bug
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Needs clarification
Newbie friendliness: 25/100