lightwave-client-1.3.1.34-33.ph4.x86_64 - firewall fail to start after upgrade
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.2k
- Forks
- 692
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Hello,
After upgrade to lightwave-client-1.3.1.34-33.ph4.x86_64 firewalld fail to start:
Installing/Updating: lightwave-client-1.3.1.34-33.ph4.x86_64
Job for firewall.service failed because the control process exited with error code.
See "systemctl status firewall.service" and "journalctl -xe" for details.
Firewall service not restarted
Reproduction steps
upgrade to lightwave-client-1.3.1.34-33.ph4.x86_64
Expected behavior
Sep 22 08:36:34 photonOS systemd[1]: Starting Firewall rules for Lightwave....
░░ Subject: A start job for unit firewall.service has begun execution
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░
░░ A start job for unit firewall.service has begun execution.
░░
░░ The job identifier is 5128.
Sep 22 08:36:34 photonOS setfirewallrules.py[12786]: Setting Lightwave firewall rules
Sep 22 08:36:35 photonOS python3[12786]: Traceback (most recent call last):
Sep 22 08:36:35 photonOS python3[12786]: File "/usr/share/config/setfirewallrules.py", line 176, in
Sep 22 08:36:35 photonOS python3[12786]: main()
Sep 22 08:36:35 photonOS python3[12786]: File "/usr/share/config/setfirewallrules.py", line 134, in main
Sep 22 08:36:35 photonOS python3[12786]: flush_ip6rules()
Sep 22 08:36:35 photonOS python3[12786]: File "/usr/share/config/setfirewallrules.py", line 88, in flush_ip6rules
Sep 22 08:36:35 photonOS python3[12786]: log_error_and_return(stderr)
Sep 22 08:36:35 photonOS python3[12786]: File "/usr/share/config/setfirewallrules.py", line 15, in log_error_and_return
Sep 22 08:36:35 photonOS python3[12786]: syslog.syslog(syslog.LOG_ERR, "Error: " + stderr)
Sep 22 08:36:35 photonOS python3[12786]: TypeError: can only concatenate str (not "bytes") to str
Sep 22 08:36:35 photonOS systemd[1]: firewall.service: Main process exited, code=exited, status=1/FAILURE
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with /usr/share/config/setfirewallrules.py, especially log_error_and_return and flush_ip6rules, then review the traceback from the firewall.service startup. Reproduce the upgrade or service start and verify that the firewall starts successfully without the reported TypeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- operating-systems, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100