Docker Swarm Encrypted Overlay Network - ESP Bug with 5.10.109-3.ph4-esx
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.2k
- Forks
- 692
- PR merge metrics
- No merged PRs in 30d
Description
I upgraded my Photon OS 4 nodes recently, which included the 5.10.109-3.ph4-esx update. As soon as I rebooted, CPU on the docker nodes started spiking and the OS (and Docker) became unresponsive. I noticed this issue https://github.com/moby/moby/issues/43359 which seems to be due to a bug with ESP in the Linux kernel. I do have my overlay networks configured for encryption, which uses ESP.
Is this patch already included in the Photon OS Linux kernel? If not, when will it be rolled into Photon OS? I apologize, I do not know much about how Bugs are posted in Linux due to the many distros. Here's the information I have from the above issue;
[PATCH] Revert "xfrm: state and policy should fail if XFRMA_IF_ID 0" and this comment: https://github.com/moby/moby/issues/43359#issuecomment-1115882598 which states the below information:
commit 9248694dac20eda06e22d8503364dc9d03df4e2f
Author: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon Mar 7 13:11:39 2022 +0100
esp: Fix possible buffer overflow in ESP transformation
commit ebe48d368e97d007bfeb76fcb065d6cfc4c96645 upstream.
The maximum message size that can be send is bigger than
the maximum site that skb_page_frag_refill can allocate.
So it is possible to write beyond the allocated buffer.
Fix this by doing a fallback to COW in that case.
v2:
Avoid get get_order() costs as suggested by Linus Torvalds.
Fixes: cac2661c53f3 ("esp4: Avoid skb_cow_data whenever possible")
Fixes: 03e2a30f6a27 ("esp6: Avoid skb_cow_data whenever possible")
Reported-by: valis <sec@valis.email>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing Photon OS 4's 5.10.109-3.ph4-esx kernel contents with commit 9248694dac20eda06e22d8503364dc9d03df4e2f and the linked ESP discussions. Check whether the fix is included in the shipped kernel and identify the relevant Photon OS release or update; done means documenting that status and any rollout timing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, docker, linux
- Domain
- networking, operating-systems, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100