vmware-tanzu / vmware-tanzu/vm-operator
Add reason to `Ready` condition if probe is cause and/or distinct condition for probe
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 134
- Forks
- 83
- Avg merge
- 4d 18m
- Merged PRs (30d)
- 73
Description
Please describe the solution you would like.
In https://github.com/vmware-tanzu/vm-operator/pull/480, a VM was deployed with a GuestInfo-based readiness probe. However, when the Ready condition transitioned to False or True, there was no Reason associated with the condition. If a readiness probe causes the VM's Ready condition to transition to True or False, then there should be some indication that this is the Reason for the condition's value. That or there should be some distinct condition related to readiness probes.
Is there anything else you would like to add?
See above.
Please tell us about your environment.
| Value | How to Obtain | |
|---|---|---|
| Supervisor version | VMware-wcp-0.1.9-73863724.x86_64 |
rpm -qa VMware-wcp on the vCenter appliance |
| Supervisor node image version | VMware-wcpovf-4.0.584-73832719.x86_64 |
rpm -qa VMware-wcpovf on the vCenter appliance |
| Kubernetes version | Client Version: v1.28.3+vmware.wcp.1Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3Server Version: v1.28.3+vmware.wcp.1 |
kubectl version |
| VM Operator version | 0.1.0-797d737-1.8.6-40cf886-73879957 |
|
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the VM operator updates the Ready condition when a GuestInfo-based readiness probe changes, using the behavior described around PR 480. Compare the current condition transition with the probe-handling path, then define whether completion means adding a probe-specific Reason or introducing a distinct readiness-probe condition, with coverage for both True and False transitions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100