vmware-tanzu / vmware-tanzu/tanzu-source-controller

ImageRepository Client cert authentication (mTLS) + CA certificate

Open
#5 0 comments 0 reactions 1 assignee View on GitHub

@rashedkvm is already working on this.

Since Jun 26, 2022.

enhancement
Dominant language
Go
Stars
7
Forks
6
Avg merge
1d 4h
Merged PRs (30d)
4

Description

ImageRepository Authentication via client certificate

For private repositories which require a certificate to authenticate,
the client certificate, private key, and the CA certificate (if self-signed), can be provided with:

spec:
  certSecretRef:
    name: regcert

The certSecretRef points to a Kubernetes secret in the same namespace as the ImageRepository:

kubectl create secret generic regcert \
  --from-file=certFile=client.crt \
  --from-file=keyFile=client.key \
  --from-file=caFile=ca.crt

Is your feature request related to a problem? Please describe
The current version of Source Controller does not support authenticating to a registry via a client certificate. Also, for the CA certificate, there is a single secret for the source. After gathering user feedback, such secrets with CA certificate data can be managed via ImageRepository resource definition. This is also consistent Flux resource APIs.

Describe alternatives you've considered

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.