vllm-project / vllm-project/production-stack
feature: Refine Functionality Test Scope to Focus on Router Image and Helm Chart
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 503
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 8
Description
Describe the feature
The current functionality test in https://github.com/vllm-project/production-stack/blob/main/.github/workflows/functionality-helm-chart.yml appears to be testing more than its intended scope. While the primary purpose should be verifying the router image build and Helm chart deployment (as seen in the Docker build command docker build --build-arg INSTALL_OPTIONAL_DEP=default -t localhost:5000/git-act-router -f docker/Dockerfile .) in link it currently includes testing of vllm/vllm-openai image deployments through values files like (values-04-multiple-models.yaml)[https://github.com/vllm-project/production-stack/blob/24049186d02329fb52ef02a4b91846a6afb46150/.github/values-04-multiple-models.yaml#L5].
Expected Behavior:
The functionality test should focus exclusively on:
- Validating the router image build process
- Testing the Helm chart deployment for the router component
- Confirming basic router functionality
Suggested Changes:
- Remove vllm/vllm-openai specific tests from the functionality workflow
- Add explicit test cases for router-specific scenarios
- Consider separating vllm/vllm-openai tests into a different workflow if needed
This change would better align the test scope with the actual purpose of this workflow and improve test clarity.
Reference Workflow Example
- https://github.com/juicedata/juicefs/blob/main/.github/workflows/chaos.yml
- https://github.com/apache/dolphinscheduler/blob/dev/.github/workflows/e2e-k8s.yml
Why do you need this feature?
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading .github/workflows/functionality-helm-chart.yml, especially the Docker build command, and inspect .github/values-04-multiple-models.yaml to identify vllm/vllm-openai coverage. Done means the workflow validates the router image build, router Helm deployment, and basic router functionality, with vllm/vllm-openai tests removed or separated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, helm, kubernetes
- Domain
- ci-cd, devops, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100