vllm-project / vllm-project/aibrix
Align `make manifest` with controller-manager role
- Dominant language
- Go
- Stars
- 5.1k
- Forks
- 694
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 98
Description
Once we run `make manifest` to generate the kustomized configurations, the controller manager role.yaml will be updated, some verbs will be removed. This is because it's not aligned with the kubebuilder Tag.
I have to add the roles manually to avoid removing some configurations by accident. We should make them aligned and always use `make manifest` to generate the configurations.
Contributor guide
Research direction
Run `make manifest` and compare the generated controller-manager `role.yaml` with the current configuration. Inspect the kubebuilder tags that define the role verbs and identify why generation removes required entries. Done means the generated configuration retains the required roles so manual edits are no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- build-system, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100