vllm-project / vllm-project/aibrix

can not use upper case for model-name

Open
#1,404 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
5.1k
Forks
697
Avg merge
1d 19h
Merged PRs (30d)
104

Description

### 🐛 Describe the bug

hi,
there are two rules for deployment:
- The Service name matches the model.aibrix.ai/name label value in the Deployment.
- The –served-model-name argument value in the Deployment command is also consistent with the Service name and model.aibrix.ai/name label.

`Service name` can not use upper case so that `–served-model-name` can not use upper case. Maybe it is better that replace the match rule for `service name` to `model.aibrix.ai/name` in service lables.

### Steps to Reproduce

-

### Expected behavior

-

### Environment

-

Contributor guide

Open the contributing guide

Research direction

Start by tracing the deployment and Service naming logic described in the issue, including the model.aibrix.ai/name label and the --served-model-name argument. Reproduce the uppercase-name case and determine where the Service-name match is enforced. Done means the naming rules accept the intended model name consistently and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.