vitest-dev / vitest-dev/vitest

spyOn mocks break with @vitest/web-worker on consecutive calls

Open
#7,441 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

p3-minor-bug
Dominant language
TypeScript
Stars
17.1k
Forks
2k
Avg merge
1d 22h
Merged PRs (30d)
94

Description

Describe the bug

When running a test suite that uses spyOn to mock something in a module, it only works for the first test and first call of spyOn.

  it('first test', async () => {
    vi.spyOn(textModule, 'getText').mockReturnValue("I'm a mocked text"); // works
  });

  it('second test', async () => {
    vi.spyOn(textModule, 'getText').mockReturnValue("I'm a mocked text");  // does not mock anything
  });

Does not matter if mockReturnValue or mockImplementation is used.
Mocking the whole module above the test suite with vi.mock works fine.

Reproduction

https://stackblitz.com/edit/vitest-webworker-spyon-bug?file=src%2Fmain.test.js

System Info
@vitest/web-worker

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @vitest/ui: latest => 3.0.5 
    @vitest/web-worker: latest => 3.0.5 
    vite: latest => 6.1.0 
    vitest: latest => 3.0.5 
Used Package Manager

npm

Validations

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked StackBlitz reproduction, especially src/main.test.js, and run the consecutive spyOn cases with @vitest/web-worker. Trace the web-worker mocking path and compare the first and second calls; done when both tests consistently receive the mocked return value.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.