vitest-dev / vitest-dev/vitest

Revive browser mode test in `packages/ui`

Open
#10,098 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

p1-chore
Dominant language
TypeScript
Stars
17.1k
Forks
2k
Avg merge
1d 22h
Merged PRs (30d)
94

Description

Currently some tests are broken and CI is disabled. I partially recovered to dog-food aria snapshot in https://github.com/vitest-dev/vitest/pull/9668 since the component and tests in packages/ui/client/components/artifacts/visual-regression are already well-scoped and seemed like a good fit.

I think packages/ui can be useful to dog-food browser mode, so probably we should make use of it. We also have test/ui for e2e but it would be nice if we can isolate per-component interaction logic properly, so they can be independently tested on browser mode.

Also enabling coverage might be also interesting.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing component and tests under packages/ui/client/components/artifacts/visual-regression, then compare the partial recovery described in PR #9668 with the test/ui end-to-end setup. Determine how per-component interaction tests should run in browser mode; the work is done when the packages/ui tests run in CI again, with coverage considered separately.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.