vitejs / vitejs/devtools

Open in Editor and Open in Finder shortcuts fail with a missing path argument

Open
#571 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

pending triage
Dominant language
TypeScript
Stars
1.2k
Forks
89
Avg merge
18h 46m
Merged PRs (30d)
24

Description

Describe the bug

Settings → Shortcuts lets me assign shortcuts to Open in Editor and Open in Finder, but pressing either shortcut does nothing visible. The browser console reports:

Error: The "paths[1]" argument must be of type string. Received undefined

Both commands failed consistently when repeated. Cmd+K still opens the command palette normally.

Reproduction

Reproduced with the repository's core playground:

  1. Start the playground with pnpm -C playgrounds/core run dev after setting up the repository.
  2. Open the playground in Chrome and authorize Vite DevTools.
  3. Go to Settings → Shortcuts.
  4. Assign Ctrl+Shift+E to Open in Editor and Ctrl+Shift+Y to Open in Finder.
  5. Close the shortcut editor, focus the host page, and press each shortcut.

Neither action opens its target; both produce the error above. Each was repeated twice with the same result. This reproduction uses the existing playground rather than a separate reduced project.

Expected behavior

A shortcut offered in Settings should have a usable execution path. Could you clarify the intended behavior for these two commands: are they meant to support user-assigned shortcuts, and if so, where should the target path come from?

Code observations and ownership

The failing path crosses both repositories:

  • Vite DevTools registers these two commands with a required path: string and showInPalette: false. Its RPC handlers resolve that path against the workspace root. The intended target of these Vite-specific commands belongs here.
  • Devframe's @devframes/hub-ui owns the shortcut settings that offer these bindings and the keyboard dispatcher that calls execute(id) without arguments. Handling commands that require arguments may therefore need a change upstream in Devframe.

Filed here because this is reproducible in Vite DevTools with its built-in commands. Could you confirm the intended shortcut behavior and whether this issue should be transferred to devframes/devframe? These observations explain the missing-path error, but do not establish whether the intended resolution is to supply a target or restrict shortcut eligibility.

System Info
  • macOS, Chrome 153
  • Vite DevTools core playground; package version: 0.7.3
  • @devframes/hub and @devframes/hub-ui: 0.9.18
Used Package Manager

pnpm

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/core/src/node/context.ts and the RPC handlers under packages/core/src/node/rpc/public, then inspect Devframe's packages/hub-ui/src/client/components/views-builtin/SettingsShortcuts.vue and packages/hub-ui/src/client/state/commands.ts. Reproduce the issue with pnpm -C playgrounds/core run dev and the listed shortcuts. Done requires an agreed shortcut behavior and both commands no longer producing the missing-path error in the appropriate repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.