visgl / visgl/react-google-maps

[Bug] Google map zoom is laggy when dashlane extension is enabled

Open
#818 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
1.9k
Forks
193
Avg merge
3d 16h
Merged PRs (30d)
13

Description

Description

This is very strange. I was porting our google map from the standard google map sdk over to this library. However, I noticed with this implementation that the zoom was laggy. I was able to track down that dashlane was doing some weird stuff via following the console.log events to those dom nodes. I don't have a slimmed down demo for this yet, I'll have to spend some time at night to get that started. I imagine this will be hard to reproduce. Once I disabled dashlane the zoom lag went away

I noticed these logs in the console in the react implementation that weren't there before.

Image Clicking on the element listed, I see dashlane has inserted it's information on the element. Image

Once I uninstall dashlane the issue goes away. However the issue didn't happen at all with the standard google maps libary.

Thank you all for the awesome library! Conflicts between extensions and libraries can be a pain to diagnose.

Steps to Reproduce
  1. Have dashlane installed.
  2. Render maybe a hundred markers.
  3. Zoom in and out. - it should be jittery/laggy
  4. Disable dashlane
  5. try it again and it should be smooth.
Environment
  • Library version: 1.5.2
  • Google maps version: weekly
  • Browser and Version: 139.0.7258.128 (Official Build) (64-bit)
  • OS: Windows 11 23H2
Logs
Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.871 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.871 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.871 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.871 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.871 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.871 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.872 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.872 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.875 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.876 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.876 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.925 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.926 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.926 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.926 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.927 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.927 kwift.CHROME.js:1 Rendering was performed in a subtree hidden by content-visibility. <div style=​"content-visibility:​ hidden;​">​…​</div>​
12:36:28.928

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported zoom lag in the react-google-maps implementation with Dashlane enabled and disabled, using roughly a hundred markers. Compare the console output and DOM changes shown in the issue with the standard Google Maps library; done requires identifying a library-side cause or a reproducible, actionable fix, but no source file or test is named.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.