`yarn test ci` runs node tests when configured for browser tests
@Pessimistress is already working on this.
Since Mar 20, 2025.
- Dominant language
- TypeScript
- Stars
- 8
- Forks
- 3
- Avg merge
- 1h 18m
- Merged PRs (30d)
- 7
Description
Hubble.gl tests are moving to browser-only tests and are failing since the ci test is running node tests. However, our ocular config (test.coverage) has testing configured for browser.
There may be a typo in test.sh:
https://github.com/visgl/dev-tools/blob/ef50bfbaed323174b37148a4716b7894069d5404/modules/dev-tools/scripts/test.sh#L68
Shouldn't this instead run node tests if coverage.test is node? Elsewhere in the dev tools (such as test.js), the default case is to run browser tests and the exception is to check if the value is node. Did we mean to do the same thing in test.sh?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.