visgl / visgl/deck.gl

[Bug] getTileData in MVTLayer doesn't fire

Open
#9,635 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Description

Description

If you add a getTileData property to your MVTLayer object, it's never called. Doesn't matter if data is set or not, it still is never called. This works fine in TileLayer objects.

Expected Behavior

MVTLayer.getTileData should be called in the same circumstances as TileLayer.getTileData

Steps to Reproduce
  1. Go to https://deck.gl/docs/api-reference/geo-layers/mvt-layer, click "Edit in Codepen"
  2. add getTileData: x => console.log(x), to the object
  3. open the console. Nothing is logged
  4. Go to https://deck.gl/docs/api-reference/geo-layers/tile-layer, click "Edit in Codepen"
  5. add getTileData: x => console.log(x), to the object
  6. open the console. Every tile is logged
Environment
  • Framework version: deck.gl@9.1.11
  • Browser: Vivaldi
  • OS: MacOS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing MVTLayer and TileLayer behavior using the linked API-reference CodePen examples, with getTileData as the entry point. Reproduce the missing console output in MVTLayer, then trace how tile data callbacks are handled. Done means getTileData is called for MVTLayer tiles under the same circumstances as TileLayer.getTileData.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.