visgl / visgl/deck.gl

[Doc] Some examples still recommend use of removed depthTest parameter

Open
#9,470 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

doc
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Description

Link

https://github.com/search?q=repo%3Avisgl%2Fdeck.gl+depthTest&type=code

Description

I noticed that setting depthTest: false on my layer parameters stopped working after upgrading from 9.0.x to 9.1.x. My understanding is that this is intentional, as these parameters are passed straight to luma.gl and in luma.gl V9 those parameters were changed to align with WebGPU, so depthTest is out and depthCompare is in.

If that understanding is correct, there are a number of places in the docs which still refer to depthTest (or other removed WebGL parameters) which could stand to be updated.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked repository code search for depthTest and review each documentation example that still recommends it. Confirm the relevant parameter names against the referenced luma.gl change, then update the affected documentation so examples no longer recommend removed WebGL parameters and verify the search finds no stale guidance.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.