[Feat] MVTLayer Cartesian Coordinates
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 14.6k
- Forks
- 2.3k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 42
Description
Target Use Case
MVTLayer incorrectly visualizes a vector tile dataset in Cartesian coordinates in OrthographicView.
https://codepen.io/s-n-i/pen/KwPeapW
I would like to make MVTLayer compatible with this use case.
Proposal
Changing the modelMatrix like this results in correct visualization:
https://github.com/s-n-i/deck.gl/commit/4cacc13111b6204430ce8f6445726d8c9f691216
https://codepen.io/s-n-i/pen/ZYzRLYX
I was wondering if MVTLayer is already intended to support Cartesian coordinates because it appears to infer a Cartesian coordinate system from !this.context.viewport.resolution in the source code here. If Cartesian coordinates are already intended to be supported, I can change this issue to a bug ticket.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at modules/geo-layers/src/mvt-layer/mvt-layer.ts around line 268 and compare its coordinate-system handling with commit 4cacc13111b6204430ce8f6445726d8c9f691216. Use the linked CodePen examples to verify that MVTLayer renders Cartesian-coordinate vector tiles correctly in OrthographicView.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100