visgl / visgl/deck.gl

[Feat] Non-smooth scrolling for doubleClickZoom

Open
#9,053 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Description

Target Use Case

I am using a OrthographicView of which I manage the viewState myself/externally as described in the Docs.

I had enabled smooth scrollZoom earlier, but realized that zooming through doubleClick is still smooth, calling onViewStateChange multiple times per zoom step.
I think it would be beneficial if this could also be controlled by the controller options.

Proposal

My suggestion is to also accept an object as parameter for doubleClickZoom, similar to scrollZoom where smooth scrolling can be controlled (and potentially also speed for consistency).

Further Notes

From my experiments I saw that the smooth zomming is based on the controllers transitionDuration and interpolator. I have now set the transitionDuration to 0 for now, which also made the doubleClick zooming non-smooth. This link is not obvious from the docs and could also be improved.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the controller options documentation linked in the issue, then trace the doubleClickZoom and scrollZoom entry points and how transitionDuration and interpolator affect OrthographicView state changes. Done means doubleClickZoom accepts the proposed configurable behavior and the documentation makes its relationship to transitionDuration clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.