[Bug] An exception during Tile3DLayer loading doesn't trigger DeckGL `onError` callback.

Open
#8,755 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

Start with the stack entries in tileset-3d.ts and tile-3d-layer.ts, especially _loadTileset and updateState, then trace how the DeckGL onError callback is reached. Use the linked CodePen reproduction to verify that an exception during Tile3DLayer loading invokes onError instead of only appearing in the console.

Written by the indexing model from the issue text.

Description

bug
Description

An exception during Tile3DLayer loading doesn't trigger DeckGL onError callback.
callback is ignored.
An error appears in the console.

Expected Behavior

It is expected for an error/exception in Deck.gl to be caught and onError callback to be called.

Steps to Reproduce

https://codepen.io/Igor-Dykhta/pen/gOyvbYM

Environment
  • Framework version: 8.9.27
Logs

The stack for the error in our app:

constructor (tileset-3d.ts:291)
_loadTileset (tile-3d-layer.ts:204)
await in _loadTileset (async)
updateState (tile-3d-layer.ts:119)
_update (layer.ts:944)
_initialize (layer.ts:886)
_initializeLayer (layer-manager.ts:339)
_updateSublayersRecursively (layer-manager.ts:303)
_updateLayers (layer-manager.ts:258)
setLayers (layer-manager.ts:206)
updateLayers2 (layer-manager.ts:218)
_onRenderFrame (deck.ts:1032)
onRender (animation-loop.js:269)
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from visgl/deck.gl

All issues in visgl/deck.gl

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.