[Bug] "effects is not iterable: undefined"

Open
#8,113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
data-visualization, frontend

Research direction

Start by reproducing the error with the Deck constructor and an explicitly undefined effects value in the React setup. Trace how the Deck options type and effects value are handled, then verify that the runtime behavior matches the optional type contract without throwing. The issue does not name a source file or test to run.

Written by the indexing model from the issue text.

Description

bug
Description

The type for effects is an optional type, however deck throws when an undefined value is passed.

Flavors
  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS
Expected Behavior

Seems like the effects props is expected to be optional, so it should guard for that. Or, the type should be non-optional.

Steps to Reproduce
new Deck({
  ...
  effects: undefined
})
Environment
  • Framework version: 8.9
  • Browser: Chrome
  • OS: MacOS
Logs
Screen Shot 2023-09-13 at 4 24 13 PM
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from visgl/deck.gl

All issues in visgl/deck.gl

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.