[Bug] TerrainLayer and GeoJsonLayer inconsistency when offset mode
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 14.6k
- Forks
- 2.3k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 42
Description
Description
(first, thank you for this neat feature ! I've been waiting for it, glad to see it coming to Deck !)
I can see inconsistency between the offset mode and the drape mode. The tops of hills are cut in offset mode. This does not apped with drape mode.
-
drape mode:
-
offset mode:
(in this example there is an elevation of 10 in offset mode)
Flavors
- React
- Python/Jupyter notebook
- MapboxLayer
- GoogleMapsOverlay
- CartoLayer
- DeckLayer/DeckRenderer for ArcGIS
Expected Behavior
Same as drape mode.
Steps to Reproduce
i can provide a git repo if needed
Environment
- Framework version: 8.9.3
- Browser: chrome & FF
- OS: Windows
Logs
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TerrainLayer and GeoJsonLayer offset and drape modes described in the issue, using deck.gl 8.9.3 in Chrome or Firefox on Windows. Reproduce the hill-top clipping with an offset elevation of 10 and compare it with drape mode; done means offset mode matches drape mode without cutting off hill tops.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100