[Feat] Rotation in OrbitView around the focus point (click location) instead of target position
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 14.6k
- Forks
- 2.3k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 42
Description
Target Use Case
We are using DeckGL in our opensource project WebViz, a react component for subsurface visualization. We are using OrbitView to visualize 3d subsurface model. (https://github.com/equinor/webviz-subsurface-components/)
In this we experienced an issue with the rotation point of the OrbitView where it rotates around the target position, which is center of the viewport. While this works fine when the object is positioned at the center, but when the object is away from center, the rotation doesn't provide good user experience.
As a user, we would like to rotate the object and not the camera, for this we propose to allow a mechanism to set the rotation point as point of click, and rotate the object around that point.
Proposal
To allow a mechanism to set the rotation point as point of click, and rotate the object around that point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the OrbitView interaction entry point and trace how rotation currently uses the target position. Review the proposal for using the click location as the rotation point, then determine the expected behavior for objects away from the viewport center and add coverage for the new interaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100