[Bug] map query more than 2048 chars doesn't send geoColumn
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 14.6k
- Forks
- 2.3k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 42
Description
Description
Using a CartoLayer with geomColumn from spatial index (h3/quadbin) including a source type MAP_TYPES.QUERY and a SQL sentence greather than 2048 characters, internally it does a request from POST to maps api, but this request not include geoColumn, aggregationExp nor aggregationResLevel parameter
Source:
https://github.com/visgl/deck.gl/blob/master/modules/carto/src/api/maps-v3-client.ts#L212
Flavors
- React
- Python/Jupyter notebook
- MapboxLayer
- GoogleMapsOverlay
- CartoLayer
- DeckLayer/DeckRenderer for ArcGIS
Expected Behavior
The same behaviour like a GET request
Steps to Reproduce
Create a CartoLayer with a source as sql query greather than 2048 chars and include a geomColumn diferent as default (geom)
Environment
- Framework version:
- Browser:
- OS:
Logs
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in modules/carto/src/api/maps-v3-client.ts around line 212 and compare the POST request path with the GET request parameters. Reproduce with a CartoLayer using a SQL query longer than 2048 characters and a non-default geomColumn, then verify the POST request includes the same geoColumn, aggregationExp, and aggregationResLevel values as the GET request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100