visgl / visgl/deck.gl

[Feat]add accessor `getElevationBase` for `MVTLayer`

Open
#6,941 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Description

Target Use Case

mapbox-gl provide fill-extrusion-base and fill-extrusion-height to draw extruded polygon (like buildings).

The MVTLayer does not have getElevationBase accessor like mapbox-gl's fill-extrusion-base. I know that deck.gl support 3D polygons, but Mapbox Vector Tile spec does not support altitude yet.

Proposal
const mvtLayer = new MVTLayer({
    extruded: true,
    getElevation: f => f.properties?.["fill-extrusion-height"] || 0,
    getElevationBase: f => f.properties?.["fill-extrusion-base"] || 0,
})

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the MVTLayer entry point and trace how the existing getElevation accessor is defined and consumed for extrusion. Done means MVTLayer accepts getElevationBase and uses it to position extruded polygon bases according to the feature data described in the proposal.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.