visgl / visgl/deck.gl

[Feat] Upgrade All Shaders to GLSL 3.00

Open
#6,827 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
TypeScript
Stars
14.6k
Forks
2.3k
Avg merge
2d 9h
Merged PRs (30d)
42

Description

Target Use Case

I think this is probably a good thing to do on principle. But beyond that, I can describe my use-case: I have a custom hook I would like to register that takes a usampler2D argument. This is not <GLSL 3.00 compatible (to my knowledge) but since the hook is prepended on all shaders, regardless of their version, deck.gl layers whose shaders are not GLSL 3.00 compliant will break.

Proposal

We would upgrade all shaders in the codebase to GLSL 3.00 and then allow luma.gl to do downgrade-transpilation as it usually does anyway for WebGL 1.0.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating all shaders in the deck.gl codebase and checking which are not GLSL 3.00 compliant. Review how luma.gl handles downgrade-transpilation for WebGL 1.0. The work is done when all shaders use GLSL 3.00 and existing WebGL 1.0 compatibility remains intact.

Written by the indexing model from the issue text.

Assessment

Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.