[Bug] Compilation error in GPU aggregator
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 14.6k
- Forks
- 2.3k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 42
Description
Description
Hi, this issue is a follow up to #9869.
I recently tried using DeckGL again, after upgrading to the latest version which incorporates the fix by @Pessimistress on #10191.
I was surprised to find that the compilation error reported in this issue still occurs. I checked the minimal example for the proposed fix that is linked in #10069, for which I initially reported that it worked, but got the same compilation error.
I'm not sure how to explain that, but that must be my mistake in some way... I apologize for this, maybe I got mixed up between browsers when testing the example, I don't know.
I came up with a fix that is cleaner than my previous workaround (#10069) and uses shader inputs to define the NaN value.
The aggregation transform props already included a naN field, which was not used.
I am submitting a PR to close this issue. Sorry for the confusion !
Flavors
- Script tag
- React
- Python/Jupyter notebook
- MapboxOverlay
- GoogleMapsOverlay
- CARTO
- ArcGIS
Expected Behavior
No response
Steps to Reproduce
See #9869
Environment
- Framework version: deck.gl@9.3.1
- Browser: Firefox 150
- OS: Linux Mint 22.2
Logs
See #9869
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction and prior context in #9869 and the minimal example linked from #10069. Inspect the aggregation transform props, especially the existing naN field, and the shader inputs involved in the GPU aggregator; done means the compilation error no longer occurs in the reported DeckGL usage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100