virtualsquare / virtualsquare/vde-2
vde_router: dhcp line in config file not terminating with "<return>" gets mishandled
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 255
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
vderouter.conf:
connect /sockets/vde.ctl
ifconfig eth0 add 172.16.4.1 255.255.255.0
dhcpd start eth0 172.16.4.11 172.16.4.21<no return>/new line
Result:
Created interface eth0
1000 Success
0000 DATA END WITH '.'
.
1000 Success
Invalid pool end address "172.16.4.21.0"
1022 Invalid argument
VDE Router
(C) D.Lacamera 2011 - GPLv2
VDE-Router$
Adding a new line at the end fixes it, but of course the error message and result is a little confusing.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the vde_router handling of the dhcp line shown in vderouter.conf, focusing on how input ending without a return is parsed. Reproduce the command with and without the final newline and compare the resulting pool address and error output; done means the no-newline form is handled consistently without the malformed address reported here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100