viperproject / viperproject/viperserver
Minimal ViperConfig for ViperCoreServer
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 16
- Forks
- 17
- Avg merge
- 19m
- Merged PRs (30d)
- 5
Description
Gobra Server has emitted the following error during CI on a Windows machine:
[scallop] Error: Validation failure for 'port' option parameters:
Gobra Server was configured to use port 50009 but this port configuration is handled by Gobra Server and is not forwarded to ViperCoreServer (we pass an empty array of args to ViperCoreServer).
However, I couldn't find any other component that could cause the above error and I suspect ViperConfig somehow being unable to find a free port (which is the default behavior).
As ViperCoreServer does not seem to use any port (which is also not a task for ViperCoreServer), I request to remove this config option from ViperConfig and maybe move it to a separate config (e.g. ViperHttpConfig).
As part of this change, one could strip ViperConfig down to the minimum set of options that ViperCoreServer needs (and therefore call it ViperCoreServerConfig).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting ViperConfig and tracing how the empty argument array reaches ViperCoreServer. Compare the options ViperCoreServer actually needs with the port configuration handled by Gobra Server, then determine whether a separate ViperHttpConfig is necessary. Done means the core server has only its required configuration and the Windows CI validation failure is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100