violentmonkey / violentmonkey/types
Can we remove `chrome-types` and only depend on `browser`?
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 12
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/violentmonkey/types/blob/92a58bafc425307365851261f8752e94282509d4/index.d.ts#L198
Could we only use browser.* instead of a union of two similar types? The same applies to the other cases.
This would make the type parsing much easier.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with index.d.ts at the linked line and inspect the other cases that use the same union of chrome-types and browser types. Check how the declarations are exposed and verify that all such cases consistently use browser.* only; done means chrome-types is no longer needed and the type declarations still parse correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100