vinyldns / vinyldns/vinyldns-cli
Update 'groups (when none exist)' integration tests
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
As discovered in code review for PR #85, it appears that the containerized VinylDNS API used in integration tests ships with a pre-established globalACLGroup group. I haven't investigated, but it's possible this is unique to 0.9.7 (previously, prior to PR #85, VinylDNS API 0.9.3 was used in the integration tests).
We should probably clean this up. Perhaps via one of the following options...
a) remove the groups (when none exist) tests
b) find some way to more accurately test the groups (when none exist) tests
c) modify the groups (when none exist) tests to be contextualized as groups (when only the pre-established group exists)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the integration tests named "groups (when none exist)" and inspect how the containerized VinylDNS API is configured in the test setup. Compare the behavior of API versions 0.9.7 and 0.9.3, then choose and document a test approach that accurately reflects the available groups scenario; the relevant tests should pass with the revised context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100