vimalloc / vimalloc/flask-jwt-extended
Original error messages lost
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 253
- PR merge metrics
- No merged PRs in 30d
Description
All error handler callbacks should include the original error message in the parameters.
E.g, the _expired_token_callback takes e.jwt_header, e.jwt_data as parameters, thus the original error message is lost when setting the expired_token_loader.
Either the entire error should be set as parameter, I.e. _expired_token_callback(e: Exception) or alternatively you could add the error message as a string _expired_token_callback(e.jwt_header, e.jwt_data, str(e)).
The same applies for all error handlers which do not include the error message.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating _expired_token_callback, expired_token_loader, and the other error-handler callback definitions and their tests. Review each callback signature and verify that the original error message remains available through every handler; done means all handlers that currently omit it expose it consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100